NavigationController: Reload methods migration

NavigationController: Reload methods migration

Use the new Reload() method with a ReloadType from everywhere, and
remove old Reload*() methods.

BUG=670232
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
TBR=bajones@chromium.org, jam@chromium.org

Committed: https://crrev.com/6142d96f1502d098a9945ff69499321ca48e691b
Cr-Commit-Position: refs/heads/master@{#439439}

[Takashi Toyoshima, 2016-12-09 09:50:56]

Description was changed from

==========
NavigationController: Reload methods migration

Use the new Reload() method with a ReloadType from everywhere, and
remove old Reload*() methods.

BUG=670232
==========

to

==========
NavigationController: Reload methods migration

Use the new Reload() method with a ReloadType from everywhere, and
remove old Reload*() methods.

BUG=670232
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Takashi Toyoshima, 2016-12-09 09:51:24]

The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 09:51:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Takashi Toyoshima, 2016-12-09 09:52:31]

Description was changed from

==========
NavigationController: Reload methods migration

Use the new Reload() method with a ReloadType from everywhere, and
remove old Reload*() methods.

BUG=670232
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
NavigationController: Reload methods migration

Use the new Reload() method with a ReloadType from everywhere, and
remove old Reload*() methods.

BUG=670232
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Takashi Toyoshima, 2016-12-09 09:52:31]

toyoshim@chromium.org changed reviewers:
+ creis@chromium.org, jam@chromium.org

[Takashi Toyoshima, 2016-12-09 09:53:40]

toyoshim@chromium.org changed reviewers:
+ palmer@chromium.org

[Takashi Toyoshima, 2016-12-09 10:01:30]

+creis@ for content and navigation
+jam@ for chrome
+palmer for naming change in mojom

[jam, 2016-12-09 17:38:40]

https://codereview.chromium.org/2561983002/diff/20001/content/public/browser/...
File content/public/browser/navigation_controller.h (right):

https://codereview.chromium.org/2561983002/diff/20001/content/public/browser/...
content/public/browser/navigation_controller.h:359: ReloadType reload_type =
ReloadType::NORMAL) = 0;
this is not allowed by the style guide:
https://google.github.io/styleguide/cppguide.html#Default_Arguments

[palmer, 2016-12-09 21:10:32]

RS LGTM.

[Takashi Toyoshima, 2016-12-13 08:43:59]

The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 08:44:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 08:46:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 08:46:36]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Takashi Toyoshima, 2016-12-13 09:09:35]

The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 09:09:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Takashi Toyoshima, 2016-12-13 09:14:33]

The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 09:14:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 09:35:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 09:35:53]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Takashi Toyoshima, 2016-12-13 11:20:32]

https://codereview.chromium.org/2561983002/diff/20001/content/public/browser/...
File content/public/browser/navigation_controller.h (right):

https://codereview.chromium.org/2561983002/diff/20001/content/public/browser/...
content/public/browser/navigation_controller.h:359: ReloadType reload_type =
ReloadType::NORMAL) = 0;
Oops. Thanks, I'd remove default type, and reorder arguments since I and creis@
discussed argument order in the previous review, and if default argument isn't a
good idea, ReloadType looks better to be the first argument.

[Takashi Toyoshima, 2016-12-13 11:20:42]

The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 11:21:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 11:57:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 11:57:24]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Takashi Toyoshima, 2016-12-14 03:53:36]

jam: ptal

[Charlie Reis, 2016-12-15 01:32:41]

Thanks-- LGTM, but let's get jam@'s opinion on the overload idea.

https://codereview.chromium.org/2561983002/diff/120001/content/public/browser...
File content/public/browser/navigation_controller.h (right):

https://codereview.chromium.org/2561983002/diff/120001/content/public/browser...
content/public/browser/navigation_controller.h:356: // cases pass in true.  If a
transient entry is showing, initiates a new
Just curious-- it seems like there's a lot of these call sites that pass false
(counter to this old comment).  Do you think that's a problem, or is it ok in
those cases?

https://codereview.chromium.org/2561983002/diff/120001/content/public/browser...
content/public/browser/navigation_controller.h:358: virtual void
Reload(ReloadType reload_type, bool check_for_repost) = 0;
jam@, what are your thoughts on overloads?  Would it be useful to have a
Reload() method which just calls Reload(content::ReloadType::NORMAL, true)? 
(That might be a nice alternative to default params, making a lot of these call
sites a bit cleaner.)

[Takashi Toyoshima, 2016-12-15 06:21:52]

Thanks. I quickly checked all use cases that use |false|.
In short, there is only one suspicious caller, but others look reasonable
choosing |false|.

https://codereview.chromium.org/2561983002/diff/120001/chrome/browser/android...
File chrome/browser/android/vr_shell/vr_shell.cc (right):

https://codereview.chromium.org/2561983002/diff/120001/chrome/browser/android...
chrome/browser/android/vr_shell/vr_shell.cc:1083:
controller.Reload(content::ReloadType::NORMAL, false);
Probably this false is ok. I assume vr_shell is something like content_shell for
testing purpose.

https://codereview.chromium.org/2561983002/diff/120001/chrome/browser/apps/gu...
File chrome/browser/apps/guest_view/web_view_browsertest.cc (right):

https://codereview.chromium.org/2561983002/diff/120001/chrome/browser/apps/gu...
chrome/browser/apps/guest_view/web_view_browsertest.cc:1100: false);
false is ok for testing

https://codereview.chromium.org/2561983002/diff/120001/chrome/browser/autofil...
File chrome/browser/autofill/autofill_interactive_uitest.cc (right):

https://codereview.chromium.org/2561983002/diff/120001/chrome/browser/autofil...
chrome/browser/autofill/autofill_interactive_uitest.cc:1279:
web_contents->GetController().Reload(content::ReloadType::NORMAL, false);
ok for testing

https://codereview.chromium.org/2561983002/diff/120001/chrome/browser/devtool...
File chrome/browser/devtools/devtools_ui_bindings.cc (right):

https://codereview.chromium.org/2561983002/diff/120001/chrome/browser/devtool...
chrome/browser/devtools/devtools_ui_bindings.cc:1125:
web_contents_->GetController().Reload(content::ReloadType::NORMAL, false);
This would be also fine because this is debug interface and caller should
understand what they are doing, and even if something prompting are needed, it
should not be on the browser UI, but probably we need to return errors through
the debugging interface so that debugger end can handle this case correctly.

https://codereview.chromium.org/2561983002/diff/120001/chrome/browser/extensi...
File chrome/browser/extensions/extension_action_runner.cc (right):

https://codereview.chromium.org/2561983002/diff/120001/chrome/browser/extensi...
chrome/browser/extensions/extension_action_runner.cc:386:
web_contents()->GetController().Reload(content::ReloadType::NORMAL, false);
Probably, there is no case for POST here because we are handling extension://
scheme.
Also, Extensions for handling Action does not have a prompting UI.

https://codereview.chromium.org/2561983002/diff/120001/chrome/browser/history...
File chrome/browser/history/history_browsertest.cc (right):

https://codereview.chromium.org/2561983002/diff/120001/chrome/browser/history...
chrome/browser/history/history_browsertest.cc:428:
tab->GetController().Reload(content::ReloadType::NORMAL, false);
testing

https://codereview.chromium.org/2561983002/diff/120001/chrome/browser/memory/...
File chrome/browser/memory/tab_manager_unittest.cc (right):

https://codereview.chromium.org/2561983002/diff/120001/chrome/browser/memory/...
chrome/browser/memory/tab_manager_unittest.cc:422: content::ReloadType::NORMAL,
false);
testing

https://codereview.chromium.org/2561983002/diff/120001/chrome/browser/ui/brow...
File chrome/browser/ui/browser_instant_controller.cc (right):

https://codereview.chromium.org/2561983002/diff/120001/chrome/browser/ui/brow...
chrome/browser/ui/browser_instant_controller.cc:59:
web_contents_->GetController().Reload(content::ReloadType::NORMAL, false);
This is used only for NTP reload on changing search engine. So this looks fine.

https://codereview.chromium.org/2561983002/diff/120001/chrome/browser/ui/java...
File chrome/browser/ui/javascript_dialogs/javascript_dialog_browsertest.cc
(right):

https://codereview.chromium.org/2561983002/diff/120001/chrome/browser/ui/java...
chrome/browser/ui/javascript_dialogs/javascript_dialog_browsertest.cc:38:
tab->GetController().Reload(content::ReloadType::NORMAL, false);
testing

https://codereview.chromium.org/2561983002/diff/120001/content/browser/devtoo...
File content/browser/devtools/protocol/page_handler.cc (right):

https://codereview.chromium.org/2561983002/diff/120001/content/browser/devtoo...
content/browser/devtools/protocol/page_handler.cc:220: false);
devtools will be ok to use false

https://codereview.chromium.org/2561983002/diff/120001/content/browser/frame_...
File content/browser/frame_host/navigation_controller_android.cc (right):

https://codereview.chromium.org/2561983002/diff/120001/content/browser/frame_...
content/browser/frame_host/navigation_controller_android.cc:343:
navigation_controller_->Reload(ReloadType::ORIGINAL_REQUEST_URL, false);
This may be wrong?

This is called when users want to switch viewing PC version page, triggered from
the burger menu. It would be better to show prompting if possible.

I'll left a TODO here and fix this later.

https://codereview.chromium.org/2561983002/diff/120001/content/browser/frame_...
File content/browser/frame_host/navigation_controller_impl.cc (right):

https://codereview.chromium.org/2561983002/diff/120001/content/browser/frame_...
content/browser/frame_host/navigation_controller_impl.cc:392:
Reload(pending_reload_, false);
IIRC, in this code path, we already handled prompting before adding the request
to the pending queue? So this is correct.

https://codereview.chromium.org/2561983002/diff/120001/content/browser/frame_...
File content/browser/frame_host/navigation_controller_impl_browsertest.cc
(right):

https://codereview.chromium.org/2561983002/diff/120001/content/browser/frame_...
content/browser/frame_host/navigation_controller_impl_browsertest.cc:1186:
shell()->web_contents()->GetController().Reload(ReloadType::NORMAL, false);
all callers in this file are for testing.

https://codereview.chromium.org/2561983002/diff/120001/content/browser/frame_...
File content/browser/frame_host/navigation_controller_impl_unittest.cc (right):

https://codereview.chromium.org/2561983002/diff/120001/content/browser/frame_...
content/browser/frame_host/navigation_controller_impl_unittest.cc:1522:
controller.Reload(ReloadType::ORIGINAL_REQUEST_URL, false);
testing

https://codereview.chromium.org/2561983002/diff/120001/content/browser/frame_...
File content/browser/frame_host/navigator_impl_unittest.cc (right):

https://codereview.chromium.org/2561983002/diff/120001/content/browser/frame_...
content/browser/frame_host/navigator_impl_unittest.cc:832:
controller().Reload(ReloadType::NORMAL, false);
testing

https://codereview.chromium.org/2561983002/diff/120001/content/browser/frame_...
content/browser/frame_host/navigator_impl_unittest.cc:846:
controller().Reload(ReloadType::BYPASSING_CACHE, false);
ditto

https://codereview.chromium.org/2561983002/diff/120001/content/public/browser...
File content/public/browser/navigation_controller.h (right):

https://codereview.chromium.org/2561983002/diff/120001/content/public/browser...
content/public/browser/navigation_controller.h:356: // cases pass in true.  If a
transient entry is showing, initiates a new
I think this should be true unless content embedders can not have a UI for
prompting. I.e., testing module like a content_shell. I checked all callers and
put comments for each.

So all use cases except one caller look reasonable. So, I will left a TODO for
the one caller, and check it in a separate CL.

https://codereview.chromium.org/2561983002/diff/120001/content/public/browser...
content/public/browser/navigation_controller.h:358: virtual void
Reload(ReloadType reload_type, bool check_for_repost) = 0;
As I checked, actually there are many valid callers that use false. IMO,
Reload(bool) is very confusing as an alternative. So, my suggesting alternatives
are;

Plan 1 (current)
 - Reload(ReloadType, bool)

Plan 2
 - Reload(ReloadType, bool)
 - ReloadNormally(bool) - use Normal internally

 * Could not reduce typing so much.

Plan 3
 - Reload() - use Normal and true internally
 - ReloadWith(ReloadType, bool)

 * probably there are still many callers that use the second interface. So not
so interesting.

https://codereview.chromium.org/2561983002/diff/120001/content/public/test/te...
File content/public/test/test_renderer_host.cc (right):

https://codereview.chromium.org/2561983002/diff/120001/content/public/test/te...
content/public/test/test_renderer_host.cc:215:
controller().Reload(ReloadType::NORMAL, false);
for testing

https://codereview.chromium.org/2561983002/diff/120001/content/public/test/te...
content/public/test/test_renderer_host.cc:225:
controller().Reload(ReloadType::NORMAL, false);
ditto

https://codereview.chromium.org/2561983002/diff/120001/content/shell/browser/...
File content/shell/browser/shell.cc (right):

https://codereview.chromium.org/2561983002/diff/120001/content/shell/browser/...
content/shell/browser/shell.cc:265:
web_contents_->GetController().Reload(ReloadType::NORMAL, false);
shell is for testing

https://codereview.chromium.org/2561983002/diff/120001/content/shell/browser/...
content/shell/browser/shell.cc:270:
web_contents_->GetController().Reload(ReloadType::BYPASSING_CACHE, false);
ditto

https://codereview.chromium.org/2561983002/diff/120001/content/shell/browser/...
File content/shell/browser/shell_web_contents_view_delegate_mac.mm (right):

https://codereview.chromium.org/2561983002/diff/120001/content/shell/browser/...
content/shell/browser/shell_web_contents_view_delegate_mac.mm:256:
web_contents_->GetController().Reload(ReloadType::NORMAL, false);
shell for testing

https://codereview.chromium.org/2561983002/diff/120001/extensions/browser/gue...
File extensions/browser/guest_view/web_view/web_view_apitest.cc (right):

https://codereview.chromium.org/2561983002/diff/120001/extensions/browser/gue...
extensions/browser/guest_view/web_view/web_view_apitest.cc:407: false);
testing

https://codereview.chromium.org/2561983002/diff/120001/extensions/browser/gue...
File extensions/browser/guest_view/web_view/web_view_guest.cc (right):

https://codereview.chromium.org/2561983002/diff/120001/extensions/browser/gue...
extensions/browser/guest_view/web_view/web_view_guest.cc:730:
web_contents()->GetController().Reload(content::ReloadType::NORMAL, false);
IIUC, this is for Chrome Apps <webview> tag. If so, it does not have a prompting
UI. For the same reason, it provides a manifest description for API permissions.
So using false is correct.

https://codereview.chromium.org/2561983002/diff/120001/extensions/browser/gue...
extensions/browser/guest_view/web_view/web_view_guest.cc:891:
web_contents()->GetController().Reload(content::ReloadType::NORMAL, false);
ditto

[Charlie Reis, 2016-12-15 18:44:03]

https://codereview.chromium.org/2561983002/diff/120001/content/browser/frame_...
File content/browser/frame_host/navigation_controller_android.cc (right):

https://codereview.chromium.org/2561983002/diff/120001/content/browser/frame_...
content/browser/frame_host/navigation_controller_android.cc:343:
navigation_controller_->Reload(ReloadType::ORIGINAL_REQUEST_URL, false);
On 2016/12/15 06:21:52, toyoshim wrote:
> This may be wrong?
> 
> This is called when users want to switch viewing PC version page, triggered
from
> the burger menu. It would be better to show prompting if possible.
> 
> I'll left a TODO here and fix this later.

Yes, I think I agree, but we should get an Android reviewer on that when we go
to fix it later.

https://codereview.chromium.org/2561983002/diff/120001/content/public/browser...
File content/public/browser/navigation_controller.h (right):

https://codereview.chromium.org/2561983002/diff/120001/content/public/browser...
content/public/browser/navigation_controller.h:356: // cases pass in true.  If a
transient entry is showing, initiates a new
On 2016/12/15 06:21:52, toyoshim wrote:
> I think this should be true unless content embedders can not have a UI for
> prompting. I.e., testing module like a content_shell. I checked all callers
and
> put comments for each.
> 
> So all use cases except one caller look reasonable. So, I will left a TODO for
> the one caller, and check it in a separate CL.

Thanks for checking all these!

https://codereview.chromium.org/2561983002/diff/120001/content/public/browser...
content/public/browser/navigation_controller.h:358: virtual void
Reload(ReloadType reload_type, bool check_for_repost) = 0;
On 2016/12/15 06:21:52, toyoshim wrote:
> As I checked, actually there are many valid callers that use false. IMO,
> Reload(bool) is very confusing as an alternative. So, my suggesting
alternatives
> are;
> 
> Plan 1 (current)
>  - Reload(ReloadType, bool)
> 
> Plan 2
>  - Reload(ReloadType, bool)
>  - ReloadNormally(bool) - use Normal internally
> 
>  * Could not reduce typing so much.
> 
> Plan 3
>  - Reload() - use Normal and true internally
>  - ReloadWith(ReloadType, bool)
> 
>  * probably there are still many callers that use the second interface. So not
> so interesting.

I was suggesting Plan 3 to get John's thoughts, but I'm ok with Plan 1 as well.

[Takashi Toyoshima, 2016-12-19 05:57:44]

Description was changed from

==========
NavigationController: Reload methods migration

Use the new Reload() method with a ReloadType from everywhere, and
remove old Reload*() methods.

BUG=670232
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
NavigationController: Reload methods migration

Use the new Reload() method with a ReloadType from everywhere, and
remove old Reload*() methods.

BUG=670232
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
TBR=bauerb@chromium.org, jam@chromium.org
==========

[Takashi Toyoshima, 2016-12-19 05:58:33]

Description was changed from

==========
NavigationController: Reload methods migration

Use the new Reload() method with a ReloadType from everywhere, and
remove old Reload*() methods.

BUG=670232
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
TBR=bauerb@chromium.org, jam@chromium.org
==========

to

==========
NavigationController: Reload methods migration

Use the new Reload() method with a ReloadType from everywhere, and
remove old Reload*() methods.

BUG=670232
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
TBR=bajones@chromium.org, jam@chromium.org
==========

[Takashi Toyoshima, 2016-12-19 06:02:57]

ok, since we could not have an answer from jam@ about overloads yet, and creis@
can be ok with Plan 1 after noticing we still have considerable numbers of both
callers using with true and false, I'd submit this Plan 1 as is with TBR.

[Takashi Toyoshima, 2016-12-19 07:19:15]

The CQ bit was checked by toyoshim@chromium.org

[Takashi Toyoshima, 2016-12-19 07:19:15]

The patchset sent to the CQ was uploaded after l-g-t-m from palmer@chromium.org,
creis@chromium.org
Link to the patchset: https://codereview.chromium.org/2561983002/#ps160001
(title: "merge master")

[commit-bot: I haz the power, 2016-12-19 07:19:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 09:07:32]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1482131955294880,
"parent_rev": "7aca96a9ff790e4d02d339f75d8cd16b135f6fed", "commit_rev":
"cfd2e4bab81ff2ae4599d76604944180b402d525"}

[commit-bot: I haz the power, 2016-12-19 09:07:59]

Description was changed from

==========
NavigationController: Reload methods migration

Use the new Reload() method with a ReloadType from everywhere, and
remove old Reload*() methods.

BUG=670232
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
TBR=bajones@chromium.org, jam@chromium.org
==========

to

==========
NavigationController: Reload methods migration

Use the new Reload() method with a ReloadType from everywhere, and
remove old Reload*() methods.

BUG=670232
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
TBR=bajones@chromium.org, jam@chromium.org

Review-Url: https://codereview.chromium.org/2561983002
==========

[commit-bot: I haz the power, 2016-12-19 09:08:00]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-12-19 09:11:58]

Description was changed from

==========
NavigationController: Reload methods migration

Use the new Reload() method with a ReloadType from everywhere, and
remove old Reload*() methods.

BUG=670232
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
TBR=bajones@chromium.org, jam@chromium.org

Review-Url: https://codereview.chromium.org/2561983002
==========

to

==========
NavigationController: Reload methods migration

Use the new Reload() method with a ReloadType from everywhere, and
remove old Reload*() methods.

BUG=670232
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
TBR=bajones@chromium.org, jam@chromium.org

Committed: https://crrev.com/6142d96f1502d098a9945ff69499321ca48e691b
Cr-Commit-Position: refs/heads/master@{#439439}
==========

[commit-bot: I haz the power, 2016-12-19 09:12:00]

Patchset 9 (id:??) landed as
https://crrev.com/6142d96f1502d098a9945ff69499321ca48e691b
Cr-Commit-Position: refs/heads/master@{#439439}

[jam, 2016-12-19 18:20:40]

On 2016/12/19 06:02:57, toyoshim wrote:
> ok, since we could not have an answer from jam@ about overloads yet, and
creis@
> can be ok with Plan 1 after noticing we still have considerable numbers of
both
> callers using with true and false, I'd submit this Plan 1 as is with TBR.

sorry  I missed the earlier message. lgtm