content/browser/web_contents/web_contents_view_aura_browsertest.cc - Issue 2561983002: NavigationController: Reload methods migration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_view_aura_browsertest.cc

Issue 2561983002: NavigationController: Reload methods migration (Closed)

Patch Set: merge master Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/web_contents/web_contents_view_aura_browsertest.cc

diff --git a/content/browser/web_contents/web_contents_view_aura_browsertest.cc b/content/browser/web_contents/web_contents_view_aura_browsertest.cc

index 60f7f2d3a1f8e48953ef590b4218d1f77819ea2e..99eb6f2be35bb9fbee2eda0430e8ca1cd46f5e99 100644

--- a/content/browser/web_contents/web_contents_view_aura_browsertest.cc

+++ b/content/browser/web_contents/web_contents_view_aura_browsertest.cc

@@ -735,7 +735,7 @@ IN_PROC_BROWSER_TEST_F(WebContentsViewAuraTest, ReplaceStateReloadPushState) {

// history.replaceState shouldn't capture a screenshot

EXPECT_FALSE(screenshot_manager()->screenshot_taken_for());

screenshot_manager()->Reset();

- web_contents->GetController().Reload(true);

+ web_contents->GetController().Reload(ReloadType::NORMAL, true);

WaitForLoadStop(web_contents);

// reloading the page shouldn't capture a screenshot

// TODO (mfomitchev): currently broken. Uncomment when