Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 2587923002: Reload: "Request desktop site" feature should ask reposting (Closed)

Created:
4 years ago by Takashi Toyoshima
Modified:
4 years ago
Reviewers:
Ted C, kinuko
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org, Charlie Reis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reload: "Request desktop site" feature should ask reposting Now Android Chrome does not confirm if it is expected to repost a form on selecting "Request desktop site". This change modifies to ask it as we do in other cases. If a user reject reposting, the navigation switches to use desktop user agent strings as usuals, but only for the next navigation and following ones. BUG=675522 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/cb996c3d933656df61f80e1afc05742f9697b704 Cr-Commit-Position: refs/heads/master@{#439727}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M content/browser/frame_host/navigation_controller_android.cc View 1 chunk +1 line, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (11 generated)
Takashi Toyoshima
tedchoc: can you review this change from a viewpoint of expected Android Chrome behaviors? +kinuko ...
4 years ago (2016-12-19 08:53:40 UTC) #4
Ted C
On 2016/12/19 08:53:40, toyoshim wrote: > tedchoc: can you review this change from a viewpoint ...
4 years ago (2016-12-19 15:55:18 UTC) #9
kinuko
rs/lgtm
4 years ago (2016-12-20 03:40:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2587923002/1
4 years ago (2016-12-20 06:25:04 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-20 06:29:15 UTC) #15
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/cb996c3d933656df61f80e1afc05742f9697b704 Cr-Commit-Position: refs/heads/master@{#439727}
4 years ago (2016-12-20 06:31:12 UTC) #17
yoichio
3 years, 12 months ago (2016-12-20 08:20:59 UTC) #18

Powered by Google App Engine
This is Rietveld 408576698