|
|
Created:
4 years ago by Takashi Toyoshima Modified:
4 years ago CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org, Charlie Reis Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionReload: "Request desktop site" feature should ask reposting
Now Android Chrome does not confirm if it is expected to repost a form
on selecting "Request desktop site".
This change modifies to ask it as we do in other cases.
If a user reject reposting, the navigation switches to use desktop user
agent strings as usuals, but only for the next navigation and
following ones.
BUG=675522
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
Committed: https://crrev.com/cb996c3d933656df61f80e1afc05742f9697b704
Cr-Commit-Position: refs/heads/master@{#439727}
Patch Set 1 #
Depends on Patchset: Messages
Total messages: 18 (11 generated)
Description was changed from ========== Reload: "Request desktop site" feature should ask reposting Now Android Chrome does not confirm if it is expected to repost a form on selecting "Request desktop site". This change modifies to ask it as we do in other cases. If a user reject reposting, the navigation switches to use desktop user agent strings as usuals, but only for the next navigation and following ones. BUG=675522 ========== to ========== Reload: "Request desktop site" feature should ask reposting Now Android Chrome does not confirm if it is expected to repost a form on selecting "Request desktop site". This change modifies to ask it as we do in other cases. If a user reject reposting, the navigation switches to use desktop user agent strings as usuals, but only for the next navigation and following ones. BUG=675522 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ==========
Description was changed from ========== Reload: "Request desktop site" feature should ask reposting Now Android Chrome does not confirm if it is expected to repost a form on selecting "Request desktop site". This change modifies to ask it as we do in other cases. If a user reject reposting, the navigation switches to use desktop user agent strings as usuals, but only for the next navigation and following ones. BUG=675522 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ========== to ========== Reload: "Request desktop site" feature should ask reposting Now Android Chrome does not confirm if it is expected to repost a form on selecting "Request desktop site". This change modifies to ask it as we do in other cases. If a user reject reposting, the navigation switches to use desktop user agent strings as usuals, but only for the next navigation and following ones. BUG=675522 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ==========
toyoshim@chromium.org changed reviewers: + kinuko@chromium.org, tedchoc@chromium.org
tedchoc: can you review this change from a viewpoint of expected Android Chrome behaviors? +kinuko for OWNERS RS LGTM, +cc:creis@ (reviewed another CL that I noticed this problem, but OOO)
The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/12/19 08:53:40, toyoshim wrote: > tedchoc: can you review this change from a viewpoint of expected Android Chrome > behaviors? > > +kinuko for OWNERS RS LGTM, +cc:creis@ (reviewed another CL that I noticed this > problem, but OOO) lgtm
rs/lgtm
The CQ bit was checked by toyoshim@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1482215087117110, "parent_rev": "f0a15d38f34dc902b92075e7e071a16b91046e2a", "commit_rev": "fbcbe6aee6608bf1cd36e9f31e93054d14318e87"}
Message was sent while issue was closed.
Description was changed from ========== Reload: "Request desktop site" feature should ask reposting Now Android Chrome does not confirm if it is expected to repost a form on selecting "Request desktop site". This change modifies to ask it as we do in other cases. If a user reject reposting, the navigation switches to use desktop user agent strings as usuals, but only for the next navigation and following ones. BUG=675522 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ========== to ========== Reload: "Request desktop site" feature should ask reposting Now Android Chrome does not confirm if it is expected to repost a form on selecting "Request desktop site". This change modifies to ask it as we do in other cases. If a user reject reposting, the navigation switches to use desktop user agent strings as usuals, but only for the next navigation and following ones. BUG=675522 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2587923002 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Reload: "Request desktop site" feature should ask reposting Now Android Chrome does not confirm if it is expected to repost a form on selecting "Request desktop site". This change modifies to ask it as we do in other cases. If a user reject reposting, the navigation switches to use desktop user agent strings as usuals, but only for the next navigation and following ones. BUG=675522 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2587923002 ========== to ========== Reload: "Request desktop site" feature should ask reposting Now Android Chrome does not confirm if it is expected to repost a form on selecting "Request desktop site". This change modifies to ask it as we do in other cases. If a user reject reposting, the navigation switches to use desktop user agent strings as usuals, but only for the next navigation and following ones. BUG=675522 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/cb996c3d933656df61f80e1afc05742f9697b704 Cr-Commit-Position: refs/heads/master@{#439727} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/cb996c3d933656df61f80e1afc05742f9697b704 Cr-Commit-Position: refs/heads/master@{#439727}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2593533002/ by yoichio@chromium.org. The reason for reverting is: Caused browser_test failure: https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests%... https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.9%20Tests%... https://uberchromegw.corp.google.com/i/chromium.memory/builders/Mac%20ASan%20... https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Test... . |