Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Unified Diff: tools/gn/parser.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gn/parser.cc
diff --git a/tools/gn/parser.cc b/tools/gn/parser.cc
index 447dfcf5b0fce5466a0aad329594530fe2a25ee9..cadd89f087f955c5de46873798951a25afaed70f 100644
--- a/tools/gn/parser.cc
+++ b/tools/gn/parser.cc
@@ -803,7 +803,8 @@ void Parser::TraverseOrder(const ParseNode* root,
} else if (root->AsEnd()) {
// Nothing.
} else {
- CHECK(false) << "Unhandled case in TraverseOrder.";
+ // Unhandled case in TraverseOrder.
+ CHECK(false);
}
post->push_back(root);
@@ -821,7 +822,8 @@ void Parser::AssignComments(ParseNode* file) {
int cur_comment = 0;
for (auto* node : pre) {
if (node->GetRange().is_null()) {
- CHECK_EQ(node, file) << "Only expected on top file node";
+ // Only expected on top file node
+ CHECK_EQ(node, file);
continue;
}
const Location& start = node->GetRange().begin();

Powered by Google App Engine
This is Rietveld 408576698