tools/gn/ninja_toolchain_writer.cc - Issue 2561963002: base: Remove the string logging from CHECK().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/ninja_toolchain_writer.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)

Patch Set: checkstring: rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/ninja_toolchain_writer.cc

diff --git a/tools/gn/ninja_toolchain_writer.cc b/tools/gn/ninja_toolchain_writer.cc

index a48a8b9f84679448814b0d06e8c65b3855fe7c08..2b56bc3c6a3e41944e16a474da3860a109ed3461 100644

--- a/tools/gn/ninja_toolchain_writer.cc

+++ b/tools/gn/ninja_toolchain_writer.cc

@@ -87,7 +87,8 @@ void NinjaToolchainWriter::WriteToolRule(const Toolchain::ToolType type,

EscapeOptions options;

options.mode = ESCAPE_NINJA_PREFORMATTED_COMMAND;

- CHECK(!tool->command().empty()) << "Command should not be empty";

+ // Command should not be empty

+ CHECK(!tool->command().empty());

WriteRulePattern("command", tool->command(), options);

WriteRulePattern("description", tool->description(), options);