Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Unified Diff: tools/gn/substitution_pattern.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gn/substitution_pattern.cc
diff --git a/tools/gn/substitution_pattern.cc b/tools/gn/substitution_pattern.cc
index c8e548998440e4814fc11f359ce0c6c922aeecec..c6f2ead23f5a4a9dfef560ecf0b1527d1b6a7fd0 100644
--- a/tools/gn/substitution_pattern.cc
+++ b/tools/gn/substitution_pattern.cc
@@ -100,7 +100,8 @@ bool SubstitutionPattern::Parse(const std::string& str,
SubstitutionPattern SubstitutionPattern::MakeForTest(const char* str) {
Err err;
SubstitutionPattern pattern;
- CHECK(pattern.Parse(str, nullptr, &err)) << err.message();
+ if (!pattern.Parse(str, nullptr, &err))
+ LOG(FATAL) << err.message();
return pattern;
}

Powered by Google App Engine
This is Rietveld 408576698