Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/gn/ninja_binary_target_writer.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« remoting/host/curtain_mode_mac.cc ('K') | « tools/gn/command_format.cc ('k') | tools/gn/ninja_copy_target_writer.cc » ('j') | ui/base/template_expressions.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_binary_target_writer.cc
diff --git a/tools/gn/ninja_binary_target_writer.cc b/tools/gn/ninja_binary_target_writer.cc
index 9772b85a1eb01d03ad3d2df35caae72f7914b8e9..5547b4056a750362fd088339549d57182fe2bc84 100644
--- a/tools/gn/ninja_binary_target_writer.cc
+++ b/tools/gn/ninja_binary_target_writer.cc
@@ -404,9 +404,8 @@ void NinjaBinaryTargetWriter::WriteCompilerVars(
}
OutputFile NinjaBinaryTargetWriter::WriteInputsStampAndGetDep() const {
- CHECK(target_->toolchain())
- << "Toolchain not set on target "
- << target_->label().GetUserVisibleName(true);
+ // Toolchain not set on target |target_->label().GetUserVisibleName(true)|.
+ CHECK(target_->toolchain());
if (target_->inputs().size() == 0)
return OutputFile(); // No inputs
« remoting/host/curtain_mode_mac.cc ('K') | « tools/gn/command_format.cc ('k') | tools/gn/ninja_copy_target_writer.cc » ('j') | ui/base/template_expressions.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698