Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/gn/ninja_copy_target_writer.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« remoting/host/curtain_mode_mac.cc ('K') | « tools/gn/ninja_binary_target_writer.cc ('k') | tools/gn/ninja_target_writer.cc » ('j') | ui/base/template_expressions.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_copy_target_writer.cc
diff --git a/tools/gn/ninja_copy_target_writer.cc b/tools/gn/ninja_copy_target_writer.cc
index b0313bec3f279dc55bc02a7cbaf1f629d2fa57b4..1e94542d81833f0f86e90848684aa98eef887add 100644
--- a/tools/gn/ninja_copy_target_writer.cc
+++ b/tools/gn/ninja_copy_target_writer.cc
@@ -63,8 +63,8 @@ void NinjaCopyTargetWriter::WriteCopyRules(
CHECK(target_->action_values().outputs().list().size() == 1);
const SubstitutionList& output_subst_list =
target_->action_values().outputs();
- CHECK_EQ(1u, output_subst_list.list().size())
- << "Should have one entry exactly.";
+ // Should have one entry exactly.
+ CHECK_EQ(1u, output_subst_list.list().size());
const SubstitutionPattern& output_subst = output_subst_list.list()[0];
std::string tool_name =
« remoting/host/curtain_mode_mac.cc ('K') | « tools/gn/ninja_binary_target_writer.cc ('k') | tools/gn/ninja_target_writer.cc » ('j') | ui/base/template_expressions.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698