Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/gn/command_format.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« remoting/host/curtain_mode_mac.cc ('K') | « tools/gn/args.cc ('k') | tools/gn/ninja_binary_target_writer.cc » ('j') | ui/base/template_expressions.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/command_format.cc
diff --git a/tools/gn/command_format.cc b/tools/gn/command_format.cc
index 0849762550a211966247e42fadafa26d153e2b32..7091daa0cd74fd4b1903729a9144114657fb7727 100644
--- a/tools/gn/command_format.cc
+++ b/tools/gn/command_format.cc
@@ -637,7 +637,8 @@ int Printer::Expr(const ParseNode* root,
} else if (const EndNode* end = root->AsEnd()) {
Print(end->value().value());
} else {
- CHECK(false) << "Unhandled case in Expr.";
+ // Unhandled case in Expr.
+ CHECK(false);
}
if (parenthesized)
« remoting/host/curtain_mode_mac.cc ('K') | « tools/gn/args.cc ('k') | tools/gn/ninja_binary_target_writer.cc » ('j') | ui/base/template_expressions.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698