Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/gn/args.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« remoting/host/curtain_mode_mac.cc ('K') | « tools/android/forwarder2/socket.cc ('k') | tools/gn/command_format.cc » ('j') | ui/base/template_expressions.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/args.cc
diff --git a/tools/gn/args.cc b/tools/gn/args.cc
index f81ffbe09a39e11a527d4dcf8741294c0dab03ee..b4a9b6014b7a3cbdf85b052f32736896d127e36c 100644
--- a/tools/gn/args.cc
+++ b/tools/gn/args.cc
@@ -306,7 +306,8 @@ void Args::SetSystemVarsLocked(Scope* dest) const {
else if (os_arch == "mips")
arch = kPPC64;
else
- CHECK(false) << "OS architecture not handled. (" << os_arch << ")";
+ // OS architecture not handled. (|os_arch|)
+ CHECK(false);
// Save the OS and architecture as build arguments that are implicitly
// declared. This is so they can be overridden in a toolchain build args
« remoting/host/curtain_mode_mac.cc ('K') | « tools/android/forwarder2/socket.cc ('k') | tools/gn/command_format.cc » ('j') | ui/base/template_expressions.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698