tools/android/forwarder2/socket.cc - Issue 2561963002: base: Remove the string logging from CHECK().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/android/forwarder2/socket.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)

Patch Set: checkstring: rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/android/forwarder2/socket.cc

diff --git a/tools/android/forwarder2/socket.cc b/tools/android/forwarder2/socket.cc

index 65dcbd0b579b9e750f5738db91d4dce0e6979012..0d87662c4d2f6117d116394dae9602c3f2091d30 100644

--- a/tools/android/forwarder2/socket.cc

+++ b/tools/android/forwarder2/socket.cc

@@ -158,7 +158,8 @@ bool Socket::InitTcpSocket(const std::string& host, int port) {

} else if (!Resolve(host)) {

return false;

}

- CHECK(FamilyIsTCP(family_)) << "Invalid socket family.";

+ // Invalid socket family.

+ CHECK(FamilyIsTCP(family_));

if (family_ == AF_INET) {

addr_.addr4.sin_port = htons(port_);

addr_ptr_ = reinterpret_cast<sockaddr*>(&addr_.addr4);