Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: third_party/crashpad/crashpad/util/win/exception_handler_server.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/crashpad/crashpad/util/win/exception_handler_server.cc
diff --git a/third_party/crashpad/crashpad/util/win/exception_handler_server.cc b/third_party/crashpad/crashpad/util/win/exception_handler_server.cc
index 70955c825b73afa1e56840fa0d23231d055f5519..358f6b638e833e72bf21dc16bb0b9a5e133a1106 100644
--- a/third_party/crashpad/crashpad/util/win/exception_handler_server.cc
+++ b/third_party/crashpad/crashpad/util/win/exception_handler_server.cc
@@ -312,7 +312,8 @@ void ExceptionHandlerServer::Run(Delegate* delegate) {
pipe = first_pipe_instance_.release();
} else {
pipe = CreateNamedPipeInstance(pipe_name_, i == 0);
- PCHECK(pipe != INVALID_HANDLE_VALUE) << "CreateNamedPipe";
+ // CreateNamedPipe
+ CHECK(pipe != INVALID_HANDLE_VALUE);
}
// Ownership of this object (and the pipe instance) is given to the new
@@ -327,7 +328,8 @@ void ExceptionHandlerServer::Run(Delegate* delegate) {
shutdown_token);
thread_handles[i].reset(
CreateThread(nullptr, 0, &PipeServiceProc, context, 0, nullptr));
- PCHECK(thread_handles[i].is_valid()) << "CreateThread";
+ // CreateThread
+ CHECK(thread_handles[i].is_valid());
}
delegate->ExceptionHandlerServerStarted();

Powered by Google App Engine
This is Rietveld 408576698