Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Unified Diff: third_party/crashpad/crashpad/util/synchronization/semaphore_win.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/crashpad/crashpad/util/synchronization/semaphore_win.cc
diff --git a/third_party/crashpad/crashpad/util/synchronization/semaphore_win.cc b/third_party/crashpad/crashpad/util/synchronization/semaphore_win.cc
index 962c7baeac6aa09a4aad20dbab982d7acfba7820..bef87e04edbf8137d62566b7b08a78763ce21d2f 100644
--- a/third_party/crashpad/crashpad/util/synchronization/semaphore_win.cc
+++ b/third_party/crashpad/crashpad/util/synchronization/semaphore_win.cc
@@ -25,7 +25,8 @@ Semaphore::Semaphore(int value)
value,
std::numeric_limits<LONG>::max(),
nullptr)) {
- PCHECK(semaphore_) << "CreateSemaphore";
+ // CreateSemaphore
+ CHECK(semaphore_);
}
Semaphore::~Semaphore() {
@@ -39,7 +40,8 @@ void Semaphore::Wait() {
bool Semaphore::TimedWait(double seconds) {
DCHECK_GE(seconds, 0.0);
DWORD rv = WaitForSingleObject(semaphore_, static_cast<DWORD>(seconds * 1E3));
- PCHECK(rv == WAIT_OBJECT_0 || rv == WAIT_TIMEOUT) << "WaitForSingleObject";
+ // WaitForSingleObject
+ CHECK(rv == WAIT_OBJECT_0 || rv == WAIT_TIMEOUT);
return rv == WAIT_OBJECT_0;
}

Powered by Google App Engine
This is Rietveld 408576698