Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: third_party/protobuf/src/google/protobuf/stubs/map_util.h

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/protobuf/src/google/protobuf/stubs/map_util.h
diff --git a/third_party/protobuf/src/google/protobuf/stubs/map_util.h b/third_party/protobuf/src/google/protobuf/stubs/map_util.h
index 4cccbbedcbbfe7bd078b81b6cddb255c1cd7568b..abb3b94ea9bf96b3c995e7269f256ab7e171ec50 100644
--- a/third_party/protobuf/src/google/protobuf/stubs/map_util.h
+++ b/third_party/protobuf/src/google/protobuf/stubs/map_util.h
@@ -208,7 +208,8 @@ typename Collection::value_type::second_type::element_type&
FindLinkedPtrOrDie(const Collection& collection,
const typename Collection::value_type::first_type& key) {
typename Collection::const_iterator it = collection.find(key);
- CHECK(it != collection.end()) << "key not found: " << key;
+ // key not found.
+ CHECK(it != collection.end());
// Since linked_ptr::operator*() is a const member returning a non const,
// we do not need a version of this function taking a non const collection.
return *it->second;
@@ -337,14 +338,16 @@ bool InsertIfNotPresent(
template <class Collection>
void InsertOrDie(Collection* const collection,
const typename Collection::value_type& value) {
- CHECK(InsertIfNotPresent(collection, value)) << "duplicate value: " << value;
+ // duplicate value.
+ CHECK(InsertIfNotPresent(collection, value));
}
// Same as above except doesn't log the value on error.
template <class Collection>
void InsertOrDieNoPrint(Collection* const collection,
const typename Collection::value_type& value) {
- CHECK(InsertIfNotPresent(collection, value)) << "duplicate value.";
+ // duplicate value.
+ CHECK(InsertIfNotPresent(collection, value));
}
// Inserts the key-value pair into the collection. Dies if key was already

Powered by Google App Engine
This is Rietveld 408576698