Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1384)

Unified Diff: third_party/crashpad/crashpad/util/synchronization/semaphore_posix.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/crashpad/crashpad/util/synchronization/semaphore_posix.cc
diff --git a/third_party/crashpad/crashpad/util/synchronization/semaphore_posix.cc b/third_party/crashpad/crashpad/util/synchronization/semaphore_posix.cc
index 973f0a5d503df575e3f0b24f3397abc3e6a5168e..9e020ecc16bcf5c580bf1e992f35d91f1f57b352 100644
--- a/third_party/crashpad/crashpad/util/synchronization/semaphore_posix.cc
+++ b/third_party/crashpad/crashpad/util/synchronization/semaphore_posix.cc
@@ -26,15 +26,18 @@ namespace crashpad {
#if !defined(OS_MACOSX)
Semaphore::Semaphore(int value) {
- PCHECK(sem_init(&semaphore_, 0, value) == 0) << "sem_init";
+ // sem_init
+ CHECK(sem_init(&semaphore_, 0, value) == 0);
}
Semaphore::~Semaphore() {
- PCHECK(sem_destroy(&semaphore_) == 0) << "sem_destroy";
+ // sem_destroy
+ CHECK(sem_destroy(&semaphore_) == 0);
}
void Semaphore::Wait() {
- PCHECK(HANDLE_EINTR(sem_wait(&semaphore_)) == 0) << "sem_wait";
+ // sem_wait
+ CHECK(HANDLE_EINTR(sem_wait(&semaphore_)) == 0);
}
bool Semaphore::TimedWait(double seconds) {
@@ -44,12 +47,14 @@ bool Semaphore::TimedWait(double seconds) {
timeout.tv_nsec = (seconds - trunc(seconds)) * 1E9;
int rv = HANDLE_EINTR(sem_timedwait(&semaphore_, &timeout));
- PCHECK(rv == 0 || errno == ETIMEDOUT) << "sem_timedwait";
+ // sem_timedwait
+ CHECK(rv == 0 || errno == ETIMEDOUT);
return rv == 0;
}
void Semaphore::Signal() {
- PCHECK(sem_post(&semaphore_) == 0) << "sem_post";
+ // sem_post
+ CHECK(sem_post(&semaphore_) == 0);
}
#endif

Powered by Google App Engine
This is Rietveld 408576698