Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/crashpad/crashpad/util/file/file_io.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« remoting/host/curtain_mode_mac.cc ('K') | « third_party/crashpad/crashpad/test/scoped_temp_dir_win.cc ('k') | third_party/crashpad/crashpad/util/mac/mac_util.cc » ('j') | ui/base/template_expressions.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/crashpad/crashpad/util/file/file_io.cc
diff --git a/third_party/crashpad/crashpad/util/file/file_io.cc b/third_party/crashpad/crashpad/util/file/file_io.cc
index 98eb3404a9560af361e6065247352b4b23a589a4..4736a54863e2db6ba31211a8bdccc53e7904d3ef 100644
--- a/third_party/crashpad/crashpad/util/file/file_io.cc
+++ b/third_party/crashpad/crashpad/util/file/file_io.cc
@@ -61,9 +61,11 @@ void CheckedReadFileAtEOF(FileHandle file) {
char c;
FileOperationResult rv = ReadFile(file, &c, 1);
if (rv < 0) {
- PCHECK(rv == 0) << "read";
+ // read
+ CHECK(rv == 0);
} else {
- CHECK_EQ(rv, 0) << "read";
+ // read
+ CHECK_EQ(rv, 0);
}
}
« remoting/host/curtain_mode_mac.cc ('K') | « third_party/crashpad/crashpad/test/scoped_temp_dir_win.cc ('k') | third_party/crashpad/crashpad/util/mac/mac_util.cc » ('j') | ui/base/template_expressions.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698