Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: third_party/crashpad/crashpad/test/scoped_temp_dir_win.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/crashpad/crashpad/test/scoped_temp_dir_win.cc
diff --git a/third_party/crashpad/crashpad/test/scoped_temp_dir_win.cc b/third_party/crashpad/crashpad/test/scoped_temp_dir_win.cc
index cc4820d69be9acf36f3500c4f7d088776754d9f8..49dd1eca6ec0de3fdd4f0aeaf23629556fc32cc9 100644
--- a/third_party/crashpad/crashpad/test/scoped_temp_dir_win.cc
+++ b/third_party/crashpad/crashpad/test/scoped_temp_dir_win.cc
@@ -31,7 +31,8 @@ namespace {
base::FilePath GenerateCandidateName() {
wchar_t temp_path[MAX_PATH + 1];
DWORD path_len = GetTempPath(MAX_PATH, temp_path);
- PCHECK(path_len != 0) << "GetTempPath";
+ // GetTempPath
+ CHECK(path_len != 0);
base::FilePath system_temp_dir(temp_path);
base::string16 new_dir_name = base::UTF8ToUTF16(base::StringPrintf(
"crashpad.test.%d.%s", GetCurrentProcessId(), RandomString().c_str()));
@@ -54,7 +55,8 @@ void ScopedTempDir::Rename() {
}
}
- CHECK(false) << "Couldn't move to a new unique temp dir";
+ // Couldn't move to a new unique temp dir
+ CHECK(false);
}
// static
@@ -68,7 +70,8 @@ base::FilePath ScopedTempDir::CreateTemporaryDirectory() {
return path_to_create;
}
- CHECK(false) << "Couldn't create a new unique temp dir";
+ // Couldn't create a new unique temp dir
+ CHECK(false);
return base::FilePath();
}

Powered by Google App Engine
This is Rietveld 408576698