Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1500)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/crashpad/crashpad/util/mac/mac_util.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« remoting/host/curtain_mode_mac.cc ('K') | « third_party/crashpad/crashpad/util/file/file_io.cc ('k') | third_party/crashpad/crashpad/util/mach/child_port_handshake.cc » ('j') | ui/base/template_expressions.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/crashpad/crashpad/util/mac/mac_util.cc
diff --git a/third_party/crashpad/crashpad/util/mac/mac_util.cc b/third_party/crashpad/crashpad/util/mac/mac_util.cc
index 7c51cc2e6d8cef05e7a83396e15b481cda4d35eb..e357161b7e8babd1d7f24e348112d804b84d4bca 100644
--- a/third_party/crashpad/crashpad/util/mac/mac_util.cc
+++ b/third_party/crashpad/crashpad/util/mac/mac_util.cc
@@ -77,7 +77,8 @@ int DarwinMajorVersion() {
utsname uname_info;
int rv = uname(&uname_info);
- PCHECK(rv == 0) << "uname";
+ // uname
+ CHECK(rv == 0);
DCHECK_EQ(strcmp(uname_info.sysname, "Darwin"), 0) << "unexpected sysname "
<< uname_info.sysname;
« remoting/host/curtain_mode_mac.cc ('K') | « third_party/crashpad/crashpad/util/file/file_io.cc ('k') | third_party/crashpad/crashpad/util/mach/child_port_handshake.cc » ('j') | ui/base/template_expressions.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698