third_party/crashpad/crashpad/snapshot/win/cpu_context_win.cc - Issue 2561963002: base: Remove the string logging from CHECK().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/crashpad/crashpad/snapshot/win/cpu_context_win.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)

Patch Set: checkstring: rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/crashpad/crashpad/snapshot/win/cpu_context_win.cc

diff --git a/third_party/crashpad/crashpad/snapshot/win/cpu_context_win.cc b/third_party/crashpad/crashpad/snapshot/win/cpu_context_win.cc

index 2450ef2552108f1ee93a5004f622ea31d18d3e8c..0b16caf07900c1951fbeae2aade4771f240140df 100644

--- a/third_party/crashpad/crashpad/snapshot/win/cpu_context_win.cc

+++ b/third_party/crashpad/crashpad/snapshot/win/cpu_context_win.cc

@@ -76,7 +76,8 @@ void CommonInitializeX86Context(const T& context, CPUContextX86* out) {

"types must be equivalent");

memcpy(&out->fxsave, &context.ExtendedRegisters, sizeof(out->fxsave));

} else if (context.ContextFlags & WOW64_CONTEXT_FLOATING_POINT) {

- CHECK(false) << "TODO(scottmg): extract x87 data";

+ // TODO(scottmg): extract x87 data

+ CHECK(false);

}