third_party/crashpad/crashpad/snapshot/mac/system_snapshot_mac.cc - Issue 2561963002: base: Remove the string logging from CHECK().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/crashpad/crashpad/snapshot/mac/system_snapshot_mac.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)

Patch Set: checkstring: rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/crashpad/crashpad/snapshot/mac/system_snapshot_mac.cc

diff --git a/third_party/crashpad/crashpad/snapshot/mac/system_snapshot_mac.cc b/third_party/crashpad/crashpad/snapshot/mac/system_snapshot_mac.cc

index 3c39088f9c2bbf6c0f6798cfc0a19d5fabbaf7e4..d4a23a9d4510f705bbd6cb5aa76eebd54a5c2091 100644

--- a/third_party/crashpad/crashpad/snapshot/mac/system_snapshot_mac.cc

+++ b/third_party/crashpad/crashpad/snapshot/mac/system_snapshot_mac.cc

@@ -346,7 +346,8 @@ void SystemSnapshotMac::TimeZone(DaylightSavingTimeStatus* dst_status,

INITIALIZATION_STATE_DCHECK_VALID(initialized_);

tm local;

- PCHECK(localtime_r(&snapshot_time_->tv_sec, &local)) << "localtime_r";

+ // localtime_r

+ CHECK(localtime_r(&snapshot_time_->tv_sec, &local));

*standard_name = tzname[0];

if (daylight) {