third_party/crashpad/crashpad/snapshot/win/crashpad_snapshot_test_crashing_child.cc - Issue 2561963002: base: Remove the string logging from CHECK().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/crashpad/crashpad/snapshot/win/crashpad_snapshot_test_crashing_child.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)

Patch Set: checkstring: rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« remoting/host/curtain_mode_mac.cc ('K') | « third_party/crashpad/crashpad/snapshot/win/cpu_context_win.cc ('k') | third_party/crashpad/crashpad/snapshot/win/crashpad_snapshot_test_dump_without_crashing.cc » ('j') | ui/base/template_expressions.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/crashpad/crashpad/snapshot/win/crashpad_snapshot_test_crashing_child.cc

diff --git a/third_party/crashpad/crashpad/snapshot/win/crashpad_snapshot_test_crashing_child.cc b/third_party/crashpad/crashpad/snapshot/win/crashpad_snapshot_test_crashing_child.cc

index 2cfb99060e58946b2215d3932cd02841f6cb7c99..fb2d47a63d5dd74c8269f12328c0c84079a14c8a 100644

--- a/third_party/crashpad/crashpad/snapshot/win/crashpad_snapshot_test_crashing_child.cc

+++ b/third_party/crashpad/crashpad/snapshot/win/crashpad_snapshot_test_crashing_child.cc

@@ -35,7 +35,8 @@ int wmain(int argc, wchar_t* argv[]) {

CHECK(client.SetHandlerIPCPipe(argv[1]));

HANDLE out = GetStdHandle(STD_OUTPUT_HANDLE);

- PCHECK(out != INVALID_HANDLE_VALUE) << "GetStdHandle";

+ // GetStdHandle

+ CHECK(out != INVALID_HANDLE_VALUE);

crashpad::WinVMAddress break_address = CurrentAddress();

crashpad::CheckedWriteFile(out, &break_address, sizeof(break_address));