Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1524)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/crashpad/crashpad/minidump/minidump_file_writer.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« remoting/host/curtain_mode_mac.cc ('K') | « third_party/crashpad/crashpad/handler/win/crashy_test_program.cc ('k') | third_party/crashpad/crashpad/snapshot/mac/system_snapshot_mac.cc » ('j') | ui/base/template_expressions.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/crashpad/crashpad/minidump/minidump_file_writer.cc
diff --git a/third_party/crashpad/crashpad/minidump/minidump_file_writer.cc b/third_party/crashpad/crashpad/minidump/minidump_file_writer.cc
index 6a91ca6b2067cbc00f99723b513a3c69f8832327..02aa755ec9163710e923d6414688296758ca433b 100644
--- a/third_party/crashpad/crashpad/minidump/minidump_file_writer.cc
+++ b/third_party/crashpad/crashpad/minidump/minidump_file_writer.cc
@@ -160,7 +160,8 @@ void MinidumpFileWriter::AddStream(
MinidumpStreamType stream_type = stream->StreamType();
auto rv = stream_types_.insert(stream_type);
- CHECK(rv.second) << "stream_type " << stream_type << " already present";
+ // stream_type |stream_type| already present
+ CHECK(rv.second);
streams_.push_back(stream.release());
« remoting/host/curtain_mode_mac.cc ('K') | « third_party/crashpad/crashpad/handler/win/crashy_test_program.cc ('k') | third_party/crashpad/crashpad/snapshot/mac/system_snapshot_mac.cc » ('j') | ui/base/template_expressions.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698