Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1459)

Unified Diff: third_party/crashpad/crashpad/handler/win/crashy_test_program.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/crashpad/crashpad/handler/win/crashy_test_program.cc
diff --git a/third_party/crashpad/crashpad/handler/win/crashy_test_program.cc b/third_party/crashpad/crashpad/handler/win/crashy_test_program.cc
index b6e044c8a8ede9726d292782bfc07c36d4874bcb..18cdff5ae3021a686d91a173d8a823015d081096 100644
--- a/third_party/crashpad/crashpad/handler/win/crashy_test_program.cc
+++ b/third_party/crashpad/crashpad/handler/win/crashy_test_program.cc
@@ -83,7 +83,8 @@ void AllocateMemoryOfVariousProtections() {
// !vprot.
void* reserve = VirtualAlloc(
nullptr, arraysize(kPageTypes) * kPageSize, MEM_RESERVE, PAGE_READWRITE);
- PCHECK(reserve) << "VirtualAlloc MEM_RESERVE";
+ // VirtualAlloc MEM_RESERVE
+ CHECK(reserve);
uintptr_t reserve_as_int = reinterpret_cast<uintptr_t>(reserve);
for (size_t i = 0; i < arraysize(kPageTypes); ++i) {
@@ -92,7 +93,8 @@ void AllocateMemoryOfVariousProtections() {
kPageSize,
MEM_COMMIT,
kPageTypes[i]);
- PCHECK(result) << "VirtualAlloc MEM_COMMIT " << i;
+ // VirtualAlloc MEM_COMMIT |i|
+ CHECK(result);
}
}

Powered by Google App Engine
This is Rietveld 408576698