Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/crashpad/crashpad/handler/handler_main.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« remoting/host/curtain_mode_mac.cc ('K') | « third_party/crashpad/crashpad/client/crashpad_client_win.cc ('k') | third_party/crashpad/crashpad/handler/win/crashy_test_program.cc » ('j') | ui/base/template_expressions.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/crashpad/crashpad/handler/handler_main.cc
diff --git a/third_party/crashpad/crashpad/handler/handler_main.cc b/third_party/crashpad/crashpad/handler/handler_main.cc
index 29c5ddc14e6c4a26b7842eebb813b00f7c5a2eec..3752e1fc38ee319fd7a636e283343450152bc8ac 100644
--- a/third_party/crashpad/crashpad/handler/handler_main.cc
+++ b/third_party/crashpad/crashpad/handler/handler_main.cc
@@ -387,7 +387,8 @@ int HandlerMain(int argc, char* argv[]) {
sa.sa_flags = SA_SIGINFO;
sa.sa_sigaction = HandleSIGTERM;
int rv = sigaction(SIGTERM, &sa, &old_sa);
- PCHECK(rv == 0) << "sigaction";
+ // sigaction
+ CHECK(rv == 0);
reset_sigterm.reset(&old_sa);
}
#elif defined(OS_WIN)
« remoting/host/curtain_mode_mac.cc ('K') | « third_party/crashpad/crashpad/client/crashpad_client_win.cc ('k') | third_party/crashpad/crashpad/handler/win/crashy_test_program.cc » ('j') | ui/base/template_expressions.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698