third_party/crashpad/crashpad/client/crashpad_client_win.cc - Issue 2561963002: base: Remove the string logging from CHECK().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/crashpad/crashpad/client/crashpad_client_win.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)

Patch Set: checkstring: rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/crashpad/crashpad/client/crashpad_client_win.cc

diff --git a/third_party/crashpad/crashpad/client/crashpad_client_win.cc b/third_party/crashpad/crashpad/client/crashpad_client_win.cc

index becfc01907cee73ab0763bec6e4009478aa6ee1d..55bb7e56e45f919851358fa79541e96b878c5915 100644

--- a/third_party/crashpad/crashpad/client/crashpad_client_win.cc

+++ b/third_party/crashpad/crashpad/client/crashpad_client_win.cc

@@ -294,7 +294,8 @@ void CreatePipe(std::wstring* pipe_name, ScopedFileHANDLE* pipe_instance) {

// that a pipe name is already in use, retry up to a few times on any error.

} while (!pipe_instance->is_valid() && --tries);

- PCHECK(pipe_instance->is_valid()) << "CreateNamedPipe";

+ // CreateNamedPipe

+ CHECK(pipe_instance->is_valid());

}

struct BackgroundHandlerStartThreadData {