Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1385)

Unified Diff: third_party/crashpad/crashpad/client/crashpad_client_mac.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/crashpad/crashpad/client/crashpad_client_mac.cc
diff --git a/third_party/crashpad/crashpad/client/crashpad_client_mac.cc b/third_party/crashpad/crashpad/client/crashpad_client_mac.cc
index cc50969e7c68e6f4820f1ee7bb20e643c3ae60ae..40f50dc9bbeefdaeb53dd0f6d1c7edbf48f1f6ff 100644
--- a/third_party/crashpad/crashpad/client/crashpad_client_mac.cc
+++ b/third_party/crashpad/crashpad/client/crashpad_client_mac.cc
@@ -393,7 +393,8 @@ class HandlerStarter final : public NotifyServer::DefaultInterface {
// do so. It may serve clients in different process groups or sessions
// than its original client, and receiving signals intended for its
// original client’s process group could be harmful in that case.
- PCHECK(setsid() != -1) << "setsid";
+ // setsid
+ CHECK(setsid() != -1);
pid = fork();
if (pid < 0) {
@@ -429,7 +430,8 @@ class HandlerStarter final : public NotifyServer::DefaultInterface {
// child normally exits quickly.
int status;
pid_t wait_pid = HANDLE_EINTR(waitpid(pid, &status, 0));
- PCHECK(wait_pid != -1) << "waitpid";
+ // waitpid
+ CHECK(wait_pid != -1);
DCHECK_EQ(wait_pid, pid);
if (WIFSIGNALED(status)) {

Powered by Google App Engine
This is Rietveld 408576698