third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp - Issue 2561963002: base: Remove the string logging from CHECK().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)

Patch Set: checkstring: rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« remoting/host/curtain_mode_mac.cc ('K') | « third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.cpp ('k') | third_party/WebKit/Source/platform/text/ICUError.cpp » ('j') | ui/base/template_expressions.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp b/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp

index d36728ced3732bc601268463fe86f96f089dd5c8..388dd95146ff1bd3d71a1060adbcc13364fe1c4f 100644

--- a/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp

+++ b/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp

@@ -383,8 +383,10 @@ size_t PaintController::findOutOfOrderCachedItemForward(

<< DisplayItem::typeAsDebugString(id.type);

#endif

- if (RuntimeEnabledFeatures::paintUnderInvalidationCheckingEnabled())

- CHECK(false) << "Can't find cached display item";

+ if (RuntimeEnabledFeatures::paintUnderInvalidationCheckingEnabled()) {

+ // Can't find cached display item.

+ CHECK(false);

+ }

// We did not find the cached display item. This should be impossible, but may

// occur if there is a bug in the system, such as under-invalidation,