Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "platform/graphics/paint/PaintController.h" 5 #include "platform/graphics/paint/PaintController.h"
6 6
7 #include "platform/graphics/GraphicsLayer.h" 7 #include "platform/graphics/GraphicsLayer.h"
8 #include "platform/graphics/paint/DrawingDisplayItem.h" 8 #include "platform/graphics/paint/DrawingDisplayItem.h"
9 #include "platform/tracing/TraceEvent.h" 9 #include "platform/tracing/TraceEvent.h"
10 #include "third_party/skia/include/core/SkPictureAnalyzer.h" 10 #include "third_party/skia/include/core/SkPictureAnalyzer.h"
(...skipping 365 matching lines...) Expand 10 before | Expand all | Expand 10 after
376 addItemToIndexIfNeeded(item, i, m_outOfOrderItemIndices); 376 addItemToIndexIfNeeded(item, i, m_outOfOrderItemIndices);
377 } 377 }
378 } 378 }
379 379
380 #ifndef NDEBUG 380 #ifndef NDEBUG
381 showDebugData(); 381 showDebugData();
382 LOG(ERROR) << id.client.debugName() << ":" 382 LOG(ERROR) << id.client.debugName() << ":"
383 << DisplayItem::typeAsDebugString(id.type); 383 << DisplayItem::typeAsDebugString(id.type);
384 #endif 384 #endif
385 385
386 if (RuntimeEnabledFeatures::paintUnderInvalidationCheckingEnabled()) 386 if (RuntimeEnabledFeatures::paintUnderInvalidationCheckingEnabled()) {
387 CHECK(false) << "Can't find cached display item"; 387 // Can't find cached display item.
388 CHECK(false);
389 }
388 390
389 // We did not find the cached display item. This should be impossible, but may 391 // We did not find the cached display item. This should be impossible, but may
390 // occur if there is a bug in the system, such as under-invalidation, 392 // occur if there is a bug in the system, such as under-invalidation,
391 // incorrect cache checking or duplicate display ids. In this case, the caller 393 // incorrect cache checking or duplicate display ids. In this case, the caller
392 // should fall back to repaint the display item. 394 // should fall back to repaint the display item.
393 return kNotFound; 395 return kNotFound;
394 } 396 }
395 397
396 // Copies a cached subsequence from current list to the new list. On return, 398 // Copies a cached subsequence from current list to the new list. On return,
397 // |cachedItemIndex| points to the item after the EndSubsequence item of the 399 // |cachedItemIndex| points to the item after the EndSubsequence item of the
(...skipping 489 matching lines...) Expand 10 before | Expand all | Expand 10 after
887 m_currentPaintArtifact.getDisplayItemList(), showPictures) 889 m_currentPaintArtifact.getDisplayItemList(), showPictures)
888 .utf8() 890 .utf8()
889 .data()); 891 .data());
890 WTFLogAlways("new display item list: [%s]\n", 892 WTFLogAlways("new display item list: [%s]\n",
891 displayItemListAsDebugString(m_newDisplayItemList, showPictures) 893 displayItemListAsDebugString(m_newDisplayItemList, showPictures)
892 .utf8() 894 .utf8()
893 .data()); 895 .data());
894 } 896 }
895 897
896 } // namespace blink 898 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698