third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.cpp - Issue 2561963002: base: Remove the string logging from CHECK().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.cpp

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)

Patch Set: checkstring: rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« remoting/host/curtain_mode_mac.cc ('K') | « third_party/WebKit/Source/platform/blob/BlobData.cpp ('k') | third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp » ('j') | ui/base/template_expressions.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.cpp b/third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.cpp

index 7cb29a56d59b52c25cbddf460e7379d6cd910a90..c0e9408096437ec5bfeab68ed2f1165a92201c7a 100644

--- a/third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.cpp

+++ b/third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.cpp

@@ -34,9 +34,8 @@ DisplayItemClient::DisplayItemClient() {

DisplayItemClient::~DisplayItemClient() {

if (displayItemClientsShouldKeepAlive) {

for (auto& item : *displayItemClientsShouldKeepAlive) {

- CHECK(!item.value.contains(this))

- << "Short-lived DisplayItemClient: " << item.value.get(this)

- << ". See crbug.com/609218.";

+ // Short-lived DisplayItemClient. See crbug.com/609218.

+ CHECK(!item.value.contains(this));

}

liveDisplayItemClients->remove(this);