media/renderers/audio_renderer_impl_unittest.cc - Issue 2561963002: base: Remove the string logging from CHECK().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/renderers/audio_renderer_impl_unittest.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)

Patch Set: checkstring: rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/renderers/audio_renderer_impl_unittest.cc

diff --git a/media/renderers/audio_renderer_impl_unittest.cc b/media/renderers/audio_renderer_impl_unittest.cc

index b67788937980f81c26a5bbb9f2069170838140ae..3cca06cdac41e76c2f7f941fdd25aa78400a93e1 100644

--- a/media/renderers/audio_renderer_impl_unittest.cc

+++ b/media/renderers/audio_renderer_impl_unittest.cc

@@ -415,7 +415,8 @@ class AudioRendererImplTest : public ::testing::Test, public RendererClient {

return;

}

- CHECK(decode_cb_.is_null()) << "Overlapping decodes are not permitted";

+ // Overlapping decodes are not permitted

+ CHECK(decode_cb_.is_null());

decode_cb_ = decode_cb;

// Wake up WaitForPendingRead() if needed.