Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(843)

Unified Diff: media/gpu/rendering_helper.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/gpu/rendering_helper.cc
diff --git a/media/gpu/rendering_helper.cc b/media/gpu/rendering_helper.cc
index bcb1d0fe8b00ec2ccd128a7dca0f63b3505dce41..dfb0d3cbd262461e63488aed1ea9bad0b539d2f7 100644
--- a/media/gpu/rendering_helper.cc
+++ b/media/gpu/rendering_helper.cc
@@ -208,7 +208,8 @@ RenderingHelper::RenderingHelper() : ignore_vsync_(false) {
}
RenderingHelper::~RenderingHelper() {
- CHECK_EQ(videos_.size(), 0U) << "Must call UnInitialize before dtor.";
+ // Must call UnInitialize before dtor.
+ CHECK_EQ(videos_.size(), 0U);
Clear();
}
@@ -384,7 +385,7 @@ void RenderingHelper::Initialize(const RenderingHelperParams& params,
GL_TEXTURE_2D, thumbnails_texture_id_, 0);
GLenum fb_status = glCheckFramebufferStatusEXT(GL_FRAMEBUFFER);
- CHECK(fb_status == GL_FRAMEBUFFER_COMPLETE) << fb_status;
+ CHECK(fb_status == GL_FRAMEBUFFER_COMPLETE);
glClearColor(0.0f, 0.0f, 0.0f, 1.0f);
glClear(GL_COLOR_BUFFER_BIT);
glBindFramebufferEXT(GL_FRAMEBUFFER,

Powered by Google App Engine
This is Rietveld 408576698