Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: media/blink/multibuffer_unittest.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/blink/multibuffer_unittest.cc
diff --git a/media/blink/multibuffer_unittest.cc b/media/blink/multibuffer_unittest.cc
index ae607798dca9390a0c1bbc1dbb9d5a04e8a585c9..8f8ac31813a4294fb4f3e1f54994fb0b7d75b13e 100644
--- a/media/blink/multibuffer_unittest.cc
+++ b/media/blink/multibuffer_unittest.cc
@@ -146,8 +146,7 @@ class TestMultiBuffer : public MultiBuffer {
IntervalMap<MultiBufferBlockId, int32_t> tmp;
for (DataMap::iterator i = data_.begin(); i != data_.end(); ++i) {
CHECK(i->second); // Null poineters are not allowed in data_
- CHECK_NE(!!pinned_[i->first], lru_->Contains(this, i->first))
- << " i->first = " << i->first;
+ CHECK_NE(!!pinned_[i->first], lru_->Contains(this, i->first));
tmp.IncrementInterval(i->first, i->first + 1, 1);
}
IntervalMap<MultiBufferBlockId, int32_t>::const_iterator tmp_iterator =
@@ -169,9 +168,10 @@ class TestMultiBuffer : public MultiBuffer {
void CheckLRUState() {
for (DataMap::iterator i = data_.begin(); i != data_.end(); ++i) {
CHECK(i->second); // Null poineters are not allowed in data_
- CHECK_NE(!!pinned_[i->first], lru_->Contains(this, i->first))
- << " i->first = " << i->first;
- CHECK_EQ(1, present_[i->first]) << " i->first = " << i->first;
+ // i->first = |i->first|.
+ CHECK_NE(!!pinned_[i->first], lru_->Contains(this, i->first));
+ // i->first = |i->first|
+ CHECK_EQ(1, present_[i->first]);
}
}

Powered by Google App Engine
This is Rietveld 408576698