Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(890)

Unified Diff: media/base/test_data_util.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/test_data_util.cc
diff --git a/media/base/test_data_util.cc b/media/base/test_data_util.cc
index 9fc6332e7c387afef948b3abeed71a8dffa67b66..8a2587bcb5c734cb44401d79384b4357c59297e2 100644
--- a/media/base/test_data_util.cc
+++ b/media/base/test_data_util.cc
@@ -53,16 +53,16 @@ scoped_refptr<DecoderBuffer> ReadTestDataFile(const std::string& name) {
base::FilePath file_path = GetTestDataFilePath(name);
int64_t tmp = 0;
- CHECK(base::GetFileSize(file_path, &tmp))
- << "Failed to get file size for '" << name << "'";
+ // Failed to get file size for |name|
+ CHECK(base::GetFileSize(file_path, &tmp));
int file_size = base::checked_cast<int>(tmp);
scoped_refptr<DecoderBuffer> buffer(new DecoderBuffer(file_size));
- CHECK_EQ(file_size,
- base::ReadFile(
- file_path, reinterpret_cast<char*>(buffer->writable_data()),
- file_size)) << "Failed to read '" << name << "'";
+ // Failed to read |name|
+ CHECK_EQ(file_size, base::ReadFile(file_path, reinterpret_cast<char*>(
+ buffer->writable_data()),
+ file_size));
return buffer;
}

Powered by Google App Engine
This is Rietveld 408576698