Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: extensions/renderer/script_context.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/autofill/form_structure_browsertest.cc ('K') | « extensions/renderer/safe_builtins.cc ('k') | extensions/renderer/wake_event_page.cc » ('j') | remoting/host/curtain_mode_mac.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/script_context.cc
diff --git a/extensions/renderer/script_context.cc b/extensions/renderer/script_context.cc
index 77dc80cca73b0a64b7b4fd158157b5cdf7494fb7..90cc76da6900c49a693e63c04ac89c02f3f46730 100644
--- a/extensions/renderer/script_context.cc
+++ b/extensions/renderer/script_context.cc
@@ -121,7 +121,8 @@ ScriptContext::~ScriptContext() {
<< " extension id: " << GetExtensionID() << "\n"
<< " effective extension id: "
<< (effective_extension_.get() ? effective_extension_->id() : "");
- CHECK(!is_valid_) << "ScriptContexts must be invalidated before destruction";
+ // ScriptContexts must be invalidated before destruction
+ CHECK(!is_valid_);
}
// static
« chrome/browser/autofill/form_structure_browsertest.cc ('K') | « extensions/renderer/safe_builtins.cc ('k') | extensions/renderer/wake_event_page.cc » ('j') | remoting/host/curtain_mode_mac.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698