Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: extensions/renderer/safe_builtins.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/safe_builtins.cc
diff --git a/extensions/renderer/safe_builtins.cc b/extensions/renderer/safe_builtins.cc
index c079b4038ec285673a4c44e3df1cb7a2aa1ab1d7..8139eb7d89a853ea7701dbbb7921e983bda609b1 100644
--- a/extensions/renderer/safe_builtins.cc
+++ b/extensions/renderer/safe_builtins.cc
@@ -138,7 +138,7 @@ v8::Local<v8::Private> MakeKey(const char* name, v8::Isolate* isolate) {
void SaveImpl(const char* name,
v8::Local<v8::Value> value,
v8::Local<v8::Context> context) {
- CHECK(!value.IsEmpty() && value->IsObject()) << name;
+ CHECK(!value.IsEmpty() && value->IsObject());
context->Global()
->SetPrivate(context, MakeKey(name, context->GetIsolate()), value)
.FromJust();
@@ -149,7 +149,7 @@ v8::Local<v8::Object> Load(const char* name, v8::Local<v8::Context> context) {
context->Global()
->GetPrivate(context, MakeKey(name, context->GetIsolate()))
.ToLocalChecked();
- CHECK(value->IsObject()) << name;
+ CHECK(value->IsObject());
return v8::Local<v8::Object>::Cast(value);
}

Powered by Google App Engine
This is Rietveld 408576698