Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: content/browser/frame_host/navigation_handle_impl.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_handle_impl.cc
diff --git a/content/browser/frame_host/navigation_handle_impl.cc b/content/browser/frame_host/navigation_handle_impl.cc
index 1cfc4a4d6bc47cabd3b2aa5c47e03575807a98a7..6021ab085f928778b47ff4ab0ace17283010261e 100644
--- a/content/browser/frame_host/navigation_handle_impl.cc
+++ b/content/browser/frame_host/navigation_handle_impl.cc
@@ -190,14 +190,14 @@ const base::TimeTicks& NavigationHandleImpl::NavigationStart() {
}
bool NavigationHandleImpl::IsPost() {
- CHECK_NE(INITIAL, state_)
- << "This accessor should not be called before the request is started.";
+ // This accessor should not be called before the request is started.
+ CHECK_NE(INITIAL, state_);
return method_ == "POST";
}
const Referrer& NavigationHandleImpl::GetReferrer() {
- CHECK_NE(INITIAL, state_)
- << "This accessor should not be called before the request is started.";
+ // This accessor should not be called before the request is started.
+ CHECK_NE(INITIAL, state_);
return sanitized_referrer_;
}
@@ -206,14 +206,14 @@ bool NavigationHandleImpl::HasUserGesture() {
}
ui::PageTransition NavigationHandleImpl::GetPageTransition() {
- CHECK_NE(INITIAL, state_)
- << "This accessor should not be called before the request is started.";
+ // This accessor should not be called before the request is started.
+ CHECK_NE(INITIAL, state_);
return transition_;
}
bool NavigationHandleImpl::IsExternalProtocol() {
- CHECK_NE(INITIAL, state_)
- << "This accessor should not be called before the request is started.";
+ // This accessor should not be called before the request is started.
+ CHECK_NE(INITIAL, state_);
return is_external_protocol_;
}
@@ -225,9 +225,9 @@ RenderFrameHostImpl* NavigationHandleImpl::GetRenderFrameHost() {
// TODO(mkwst): Change this to check against 'READY_TO_COMMIT' once
// ReadyToCommitNavigation is available whether or not PlzNavigate is
// enabled. https://crbug.com/621856
- CHECK_GE(state_, WILL_PROCESS_RESPONSE)
- << "This accessor should only be called after a response has been "
- "delivered for processing.";
+ // This accessor should only be called after a response has been delivered for
+ // processing.
+ CHECK_GE(state_, WILL_PROCESS_RESPONSE);
return render_frame_host_;
}

Powered by Google App Engine
This is Rietveld 408576698