content/browser/frame_host/navigation_controller_impl.cc - Issue 2561963002: base: Remove the string logging from CHECK().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_controller_impl.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)

Patch Set: checkstring: rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/navigation_controller_impl.cc

diff --git a/content/browser/frame_host/navigation_controller_impl.cc b/content/browser/frame_host/navigation_controller_impl.cc

index c87e636b6e4410b74cd94ed4f56d4e8745c71817..6550b0da15f946b08ae1d67de862fdf6fde84174 100644

--- a/content/browser/frame_host/navigation_controller_impl.cc

+++ b/content/browser/frame_host/navigation_controller_impl.cc

@@ -1593,7 +1593,8 @@ void NavigationControllerImpl::SetSessionStorageNamespace(

static_cast<SessionStorageNamespaceImpl*>(

session_storage_namespace)))

.second;

- CHECK(successful_insert) << "Cannot replace existing SessionStorageNamespace";

+ // Cannot replace existing SessionStorageNamespace

+ CHECK(successful_insert);

}

bool NavigationControllerImpl::IsUnmodifiedBlankTab() const {