Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1332)

Unified Diff: components/test_runner/text_input_controller.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/test_runner/text_input_controller.cc
diff --git a/components/test_runner/text_input_controller.cc b/components/test_runner/text_input_controller.cc
index a57e65734b123e906446b89b8bac5c9a5cc420c6..e04d1f787e2cc6a904df76dd4c91a856d5d34f7e 100644
--- a/components/test_runner/text_input_controller.cc
+++ b/components/test_runner/text_input_controller.cc
@@ -184,8 +184,8 @@ void TextInputController::UnmarkText() {
void TextInputController::DoCommand(const std::string& text) {
if (view()->mainFrame()) {
if (!view()->mainFrame()->toWebLocalFrame()) {
- CHECK(false) << "This function cannot be called if the main frame is not"
- "a local frame.";
+ // This function cannot be called if the main frame is nota local frame.
+ CHECK(false);
}
view()->mainFrame()->toWebLocalFrame()->executeCommand(
blink::WebString::fromUTF8(text));
@@ -227,8 +227,8 @@ bool TextInputController::HasMarkedText() {
return false;
if (!view()->mainFrame()->toWebLocalFrame()) {
- CHECK(false) << "This function cannot be called if the main frame is not"
- "a local frame.";
+ // This function cannot be called if the main frame is nota local frame.
+ CHECK(false);
}
return view()->mainFrame()->toWebLocalFrame()->hasMarkedText();
@@ -239,8 +239,8 @@ std::vector<int> TextInputController::MarkedRange() {
return std::vector<int>();
if (!view()->mainFrame()->toWebLocalFrame()) {
- CHECK(false) << "This function cannot be called if the main frame is not"
- "a local frame.";
+ // This function cannot be called if the main frame is nota local frame.
+ CHECK(false);
}
blink::WebRange range = view()->mainFrame()->toWebLocalFrame()->markedRange();
@@ -256,8 +256,8 @@ std::vector<int> TextInputController::SelectedRange() {
return std::vector<int>();
if (!view()->mainFrame()->toWebLocalFrame()) {
- CHECK(false) << "This function cannot be called if the main frame is not"
- "a local frame.";
+ // This function cannot be called if the main frame is nota local frame.
+ CHECK(false);
}
blink::WebRange range =
@@ -331,8 +331,9 @@ TextInputController::GetInputMethodController() {
blink::WebLocalFrame* mainFrame = view()->mainFrame()->toWebLocalFrame();
if (!mainFrame) {
- CHECK(false) << "WebView does not have a local main frame and"
- " cannot handle input method controller tasks.";
+ // WebView does not have a local main frame and cannot handle input method
+ // controller tasks.
+ CHECK(false);
}
return mainFrame->frameWidget()->getActiveWebInputMethodController();
}

Powered by Google App Engine
This is Rietveld 408576698