Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Unified Diff: components/test_runner/test_runner_for_specific_view.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/test_runner/test_runner_for_specific_view.cc
diff --git a/components/test_runner/test_runner_for_specific_view.cc b/components/test_runner/test_runner_for_specific_view.cc
index eb6cb792baf1942d43f2cba0fdab5a6b7c7f6a3a..6f3c9db1492baeb4c7d20aad80b529d027ac991d 100644
--- a/components/test_runner/test_runner_for_specific_view.cc
+++ b/components/test_runner/test_runner_for_specific_view.cc
@@ -577,8 +577,8 @@ void TestRunnerForSpecificView::DidLosePointerLockInternal() {
bool TestRunnerForSpecificView::CallShouldCloseOnWebView() {
if (!web_view()->mainFrame()->toWebLocalFrame()) {
- CHECK(false) << "This function cannot be called if the main frame is not a "
- "local frame.";
+ // This function cannot be called if the main frame is not a local frame.
+ CHECK(false);
}
return web_view()->mainFrame()->toWebLocalFrame()->dispatchBeforeUnloadEvent(
@@ -675,8 +675,8 @@ bool TestRunnerForSpecificView::FindString(
std::string TestRunnerForSpecificView::SelectionAsMarkup() {
if (!web_view()->mainFrame()->toWebLocalFrame()) {
- CHECK(false) << "This function cannot be called if the main frame is not a "
- "local frame.";
+ // This function cannot be called if the main frame is not a local frame.
+ CHECK(false);
}
return web_view()->mainFrame()->toWebLocalFrame()->selectionAsMarkup().utf8();
}

Powered by Google App Engine
This is Rietveld 408576698