Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4582)

Unified Diff: chrome/browser/extensions/api/storage/settings_sync_processor.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/storage/settings_sync_processor.cc
diff --git a/chrome/browser/extensions/api/storage/settings_sync_processor.cc b/chrome/browser/extensions/api/storage/settings_sync_processor.cc
index 02f3f6f926627c385cab86a65020b4ea6fe9e1b6..87154d5bea5fbb399c86438a0f8fb3586f85bd5f 100644
--- a/chrome/browser/extensions/api/storage/settings_sync_processor.cc
+++ b/chrome/browser/extensions/api/storage/settings_sync_processor.cc
@@ -33,7 +33,8 @@ SettingsSyncProcessor::~SettingsSyncProcessor() {
void SettingsSyncProcessor::Init(const base::DictionaryValue& initial_state) {
DCHECK_CURRENTLY_ON(BrowserThread::FILE);
- CHECK(!initialized_) << "Init called multiple times";
+ // Init called multiple times
+ CHECK(!initialized_);
for (base::DictionaryValue::Iterator i(initial_state); !i.IsAtEnd();
i.Advance())
@@ -45,7 +46,8 @@ void SettingsSyncProcessor::Init(const base::DictionaryValue& initial_state) {
syncer::SyncError SettingsSyncProcessor::SendChanges(
const ValueStoreChangeList& changes) {
DCHECK_CURRENTLY_ON(BrowserThread::FILE);
- CHECK(initialized_) << "Init not called";
+ // Init not called
+ CHECK(initialized_);
syncer::SyncChangeList sync_changes;
std::set<std::string> added_keys;
@@ -97,7 +99,8 @@ syncer::SyncError SettingsSyncProcessor::SendChanges(
void SettingsSyncProcessor::NotifyChanges(const ValueStoreChangeList& changes) {
DCHECK_CURRENTLY_ON(BrowserThread::FILE);
- CHECK(initialized_) << "Init not called";
+ // Init not called
+ CHECK(initialized_);
for (ValueStoreChangeList::const_iterator i = changes.begin();
i != changes.end(); ++i) {

Powered by Google App Engine
This is Rietveld 408576698