Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1824)

Unified Diff: chrome/browser/devtools/device/adb/mock_adb_server.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/device/adb/mock_adb_server.cc
diff --git a/chrome/browser/devtools/device/adb/mock_adb_server.cc b/chrome/browser/devtools/device/adb/mock_adb_server.cc
index e1c5d87214c56226d46aeee735612c1bd0da6004..04a304e0a5c7715eec640ea6412f74306f888193 100644
--- a/chrome/browser/devtools/device/adb/mock_adb_server.cc
+++ b/chrome/browser/devtools/device/adb/mock_adb_server.cc
@@ -329,8 +329,9 @@ void SimpleHttpServer::Connection::OnDataRead(int count) {
void SimpleHttpServer::Connection::WriteData() {
CHECK(CalledOnValidThread());
+ // Check for overflow.
CHECK_GE(output_buffer_->capacity(),
- output_buffer_->offset() + bytes_to_write_) << "Overflow";
+ output_buffer_->offset() + bytes_to_write_);
int write_result = socket_->Write(
output_buffer_.get(),
@@ -348,8 +349,9 @@ void SimpleHttpServer::Connection::OnDataWritten(int count) {
return;
}
CHECK_GT(count, 0);
+ // Check for overflow.
CHECK_GE(output_buffer_->capacity(),
- output_buffer_->offset() + bytes_to_write_) << "Overflow";
+ output_buffer_->offset() + bytes_to_write_);
bytes_to_write_ -= count;
output_buffer_->set_offset(output_buffer_->offset() + count);

Powered by Google App Engine
This is Rietveld 408576698