Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(737)

Unified Diff: chrome/app_shim/app_mode_loader_mac.mm

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/app_shim/app_mode_loader_mac.mm
diff --git a/chrome/app_shim/app_mode_loader_mac.mm b/chrome/app_shim/app_mode_loader_mac.mm
index e4a3686f1a693d4c20903fff5b58cb95b208b88a..f60ff57fbea092f8b1a6f467412cd7f565151c3a 100644
--- a/chrome/app_shim/app_mode_loader_mac.mm
+++ b/chrome/app_shim/app_mode_loader_mac.mm
@@ -48,13 +48,15 @@ int LoadFrameworkAndStart(app_mode::ChromeAppModeInfo* info) {
// Get the current main bundle, i.e., that of the app loader that's running.
NSBundle* app_bundle = [NSBundle mainBundle];
- CHECK(app_bundle) << "couldn't get loader bundle";
+ // couldn't get loader bundle
+ CHECK(app_bundle);
// ** 1: Get path to outer Chrome bundle.
// Get the bundle ID of the browser that created this app bundle.
NSString* cr_bundle_id = base::mac::ObjCCast<NSString>(
[app_bundle objectForInfoDictionaryKey:app_mode::kBrowserBundleIDKey]);
- CHECK(cr_bundle_id) << "couldn't get browser bundle ID";
+ // couldn't get browser bundle ID
+ CHECK(cr_bundle_id);
// First check if Chrome exists at the last known location.
base::FilePath cr_bundle_path;
@@ -121,11 +123,13 @@ int LoadFrameworkAndStart(app_mode::ChromeAppModeInfo* info) {
// Read information about the this app shortcut from the Info.plist.
// Don't check for null-ness on optional items.
NSDictionary* info_plist = [app_bundle infoDictionary];
- CHECK(info_plist) << "couldn't get loader Info.plist";
+ // couldn't get loader Info.plist
+ CHECK(info_plist);
info->app_mode_id = SysNSStringToUTF8(
[info_plist objectForKey:app_mode::kCrAppModeShortcutIDKey]);
- CHECK(info->app_mode_id.size()) << "couldn't get app shortcut ID";
+ // couldn't get app shortcut ID
+ CHECK(info->app_mode_id.size());
info->app_mode_name = SysNSStringToUTF16(
[info_plist objectForKey:app_mode::kCrAppModeShortcutNameKey]);

Powered by Google App Engine
This is Rietveld 408576698