Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1013)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/android/vr_shell/ui_scene.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app_shim/app_mode_loader_mac.mm ('k') | chrome/browser/android/vr_shell/vr_controller.cc » ('j') | chrome/browser/autofill/form_structure_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/vr_shell/ui_scene.cc
diff --git a/chrome/browser/android/vr_shell/ui_scene.cc b/chrome/browser/android/vr_shell/ui_scene.cc
index be4d83b15f0660cc95ea659bc5a7ab779beae070..c47f2ff69fc0688d35527379ae7f0aee98ed98e7 100644
--- a/chrome/browser/android/vr_shell/ui_scene.cc
+++ b/chrome/browser/android/vr_shell/ui_scene.cc
@@ -72,7 +72,8 @@ void ParseFloats(const base::DictionaryValue& dict,
std::vector<float>* vec) {
for (const auto& key : keys) {
double value;
- CHECK(dict.GetDouble(key, &value)) << "parsing tag " << key;
+ // parsing tag |key|.
+ CHECK(dict.GetDouble(key, &value));
vec->push_back(value);
}
}
« no previous file with comments | « chrome/app_shim/app_mode_loader_mac.mm ('k') | chrome/browser/android/vr_shell/vr_controller.cc » ('j') | chrome/browser/autofill/form_structure_browsertest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698