Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4726)

Unified Diff: chrome/app/chrome_main_delegate.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/app/chrome_main_delegate.cc
diff --git a/chrome/app/chrome_main_delegate.cc b/chrome/app/chrome_main_delegate.cc
index da9719236a12d569031073799a30cf0a5640faa1..f33a2ebdcc876aa1330dec337485f963a1d87e21 100644
--- a/chrome/app/chrome_main_delegate.cc
+++ b/chrome/app/chrome_main_delegate.cc
@@ -440,8 +440,8 @@ void InitializeUserDataDir(base::CommandLine* command_line) {
// The browser process (which is identified by an empty |process_type|) will
// handle the error later; other processes that need the dir crash here.
- CHECK(process_type.empty()) << "Unable to get the user data directory "
- << "for process type: " << process_type;
+ // Unable to get the user data directory for process type.
+ CHECK(process_type.empty());
}
// Append the fallback user data directory to the commandline. Otherwise,
@@ -723,13 +723,13 @@ void ChromeMainDelegate::InitMacCrashReporter(
// The helper's Info.plist marks it as a background only app.
if (base::mac::IsBackgroundOnlyProcess()) {
+ // Helper application requires --type.
CHECK(command_line.HasSwitch(switches::kProcessType) &&
- !process_type.empty())
- << "Helper application requires --type.";
+ !process_type.empty());
} else {
+ // Main application forbids --type, saw |process_type|.
CHECK(!command_line.HasSwitch(switches::kProcessType) &&
- process_type.empty())
- << "Main application forbids --type, saw " << process_type;
+ process_type.empty());
}
}
@@ -869,8 +869,8 @@ void ChromeMainDelegate::PreSandboxStartup() {
ResourceBundle::GetSharedInstance().AddDataPackFromPath(
resources_pack_path, ui::SCALE_FACTOR_NONE);
#endif
- CHECK(!loaded_locale.empty()) << "Locale could not be found for " <<
- locale;
+ // Locale could not be found for |locale|.
+ CHECK(!loaded_locale.empty());
}
#if !defined(CHROME_MULTIPLE_DLL_BROWSER)

Powered by Google App Engine
This is Rietveld 408576698