Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3337)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: blimp/test/fake_engine/fake_engine.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « blimp/net/engine_connection_manager.cc ('k') | cc/debug/invalidation_benchmark.cc » ('j') | chrome/browser/autofill/form_structure_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/test/fake_engine/fake_engine.cc
diff --git a/blimp/test/fake_engine/fake_engine.cc b/blimp/test/fake_engine/fake_engine.cc
index 18d97df5a6d39d1063e5a83c6534db914d546374..66c591a306e77646bef85b8e8e88c1e0ccaff7a2 100644
--- a/blimp/test/fake_engine/fake_engine.cc
+++ b/blimp/test/fake_engine/fake_engine.cc
@@ -62,8 +62,7 @@ void FakeEngine::Start() {
grpc::Status status = lifetime_stub_->EngineReady(
&context, request, &response);
- CHECK(status.ok()) << "EngineReady RPC failed: "
- << status.error_code() << ": " << status.error_message();
+ CHECK(status.ok());
VLOG(1) << "EngineReady RPC success";
}
« no previous file with comments | « blimp/net/engine_connection_manager.cc ('k') | cc/debug/invalidation_benchmark.cc » ('j') | chrome/browser/autofill/form_structure_browsertest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698