Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Side by Side Diff: blimp/test/fake_engine/fake_engine.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "blimp/test/fake_engine/fake_engine.h" 5 #include "blimp/test/fake_engine/fake_engine.h"
6 6
7 #include <fcntl.h> 7 #include <fcntl.h>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "blimp/test/fake_engine/proto/engine.grpc.pb.h" 10 #include "blimp/test/fake_engine/proto/engine.grpc.pb.h"
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 lifetime_stub_ = Lifetime::NewStub(rendering_server_channel_); 55 lifetime_stub_ = Lifetime::NewStub(rendering_server_channel_);
56 logging_stub_ = Logging::NewStub(rendering_server_channel_); 56 logging_stub_ = Logging::NewStub(rendering_server_channel_);
57 57
58 EngineReadyRequest request; 58 EngineReadyRequest request;
59 EngineReadyResponse response; 59 EngineReadyResponse response;
60 60
61 grpc::ClientContext context; 61 grpc::ClientContext context;
62 grpc::Status status = lifetime_stub_->EngineReady( 62 grpc::Status status = lifetime_stub_->EngineReady(
63 &context, request, &response); 63 &context, request, &response);
64 64
65 CHECK(status.ok()) << "EngineReady RPC failed: " 65 CHECK(status.ok());
66 << status.error_code() << ": " << status.error_message();
67 VLOG(1) << "EngineReady RPC success"; 66 VLOG(1) << "EngineReady RPC success";
68 } 67 }
69 68
70 void FakeEngine::WaitForShutdown() { 69 void FakeEngine::WaitForShutdown() {
71 DCHECK(grpc_server_) << "FakeEngine not started."; 70 DCHECK(grpc_server_) << "FakeEngine not started.";
72 grpc_server_->Wait(); 71 grpc_server_->Wait();
73 } 72 }
74 73
75 Lifetime::Stub* FakeEngine::GetLifetimeStub() { 74 Lifetime::Stub* FakeEngine::GetLifetimeStub() {
76 return lifetime_stub_.get(); 75 return lifetime_stub_.get();
77 } 76 }
78 77
79 Logging::Stub* FakeEngine::GetLoggingStub() { 78 Logging::Stub* FakeEngine::GetLoggingStub() {
80 return logging_stub_.get(); 79 return logging_stub_.get();
81 } 80 }
82 81
83 } // namespace blimp 82 } // namespace blimp
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698