Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3699)

Unified Diff: cc/debug/invalidation_benchmark.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/debug/invalidation_benchmark.cc
diff --git a/cc/debug/invalidation_benchmark.cc b/cc/debug/invalidation_benchmark.cc
index 3923c14a3b7cfec293a7ab8929eedc600ab5e6ec..f75175ae84097897d106bcc9f0f070199b6f3fe1 100644
--- a/cc/debug/invalidation_benchmark.cc
+++ b/cc/debug/invalidation_benchmark.cc
@@ -42,10 +42,10 @@ InvalidationBenchmark::InvalidationBenchmark(
if (mode_string == "fixed_size") {
mode_ = FIXED_SIZE;
- CHECK(settings->HasKey("width"))
- << "Must provide a width for fixed_size mode.";
- CHECK(settings->HasKey("height"))
- << "Must provide a height for fixed_size mode.";
+ // Must provide a width for fixed_size mode.
+ CHECK(settings->HasKey("width"));
+ // Must provide a height for fixed_size mode.
+ CHECK(settings->HasKey("height"));
settings->GetInteger("width", &width_);
settings->GetInteger("height", &height_);
} else if (mode_string == "layer") {
@@ -55,8 +55,7 @@ InvalidationBenchmark::InvalidationBenchmark(
} else if (mode_string == "viewport") {
mode_ = VIEWPORT;
} else {
- CHECK(false) << "Invalid mode: " << mode_string
- << ". One of {fixed_size, layer, viewport, random} expected.";
+ CHECK(false);
}
}

Powered by Google App Engine
This is Rietveld 408576698