base/test/launcher/test_launcher.cc - Issue 2561963002: base: Remove the string logging from CHECK().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/test/launcher/test_launcher.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)

Patch Set: checkstring: rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/test/launcher/test_launcher.cc

diff --git a/base/test/launcher/test_launcher.cc b/base/test/launcher/test_launcher.cc

index 2f22d32d50a4dba63b902aa4006e94a22db08071..48d3434e20a3d57655ff2c9f62679b870ace9d9c 100644

--- a/base/test/launcher/test_launcher.cc

+++ b/base/test/launcher/test_launcher.cc

@@ -647,7 +647,8 @@ void TestLauncher::OnTestFinished(const TestResult& original_result) {

status_line.append("(UNKNOWN)");

} else {

// Fail very loudly so it's not ignored.

- CHECK(false) << "Unhandled test result status: " << result.status;

+ // Unhandled test result status.

+ CHECK(false);

}

fprintf(stdout, "%s\n", status_line.c_str());

fflush(stdout);