Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: base/test/multiprocess_test_android.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/test/multiprocess_test_android.cc
diff --git a/base/test/multiprocess_test_android.cc b/base/test/multiprocess_test_android.cc
index f58b452d1cb316184884c6e7e19a196ed6a90c8c..87cd5eb23e920eac4323275862e3a066b9121ce2 100644
--- a/base/test/multiprocess_test_android.cc
+++ b/base/test/multiprocess_test_android.cc
@@ -143,7 +143,8 @@ void LaunchHelper::Init(MainFunction main) {
CHECK_NE(-1, fds[1]);
pid_t pid = fork();
- PCHECK(pid >= 0) << "Fork failed";
+ // Fork failed
+ CHECK(pid >= 0);
if (pid) {
// Parent.
rv = close(fds[1]);
@@ -240,7 +241,8 @@ void LaunchHelper::DoHelper(int fd) {
void LaunchHelper::StartProcessInHelper(const StartProcessRequest* request,
std::vector<ScopedFD> fds) {
pid_t pid = fork();
- PCHECK(pid >= 0) << "Fork failed";
+ // Fork failed
+ CHECK(pid >= 0);
if (pid) {
// Helper.
StartProcessResponse resp;

Powered by Google App Engine
This is Rietveld 408576698