Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(889)

Unified Diff: base/synchronization/waitable_event_win.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/synchronization/waitable_event_win.cc
diff --git a/base/synchronization/waitable_event_win.cc b/base/synchronization/waitable_event_win.cc
index 993dbb1222427137fae077a5c0b9c3acd15bdae3..2860afe398261026dba674a5ae023d10cbbf1d68 100644
--- a/base/synchronization/waitable_event_win.cc
+++ b/base/synchronization/waitable_event_win.cc
@@ -31,7 +31,8 @@ WaitableEvent::WaitableEvent(ResetPolicy reset_policy,
WaitableEvent::WaitableEvent(win::ScopedHandle handle)
: handle_(std::move(handle)) {
- CHECK(handle_.IsValid()) << "Tried to create WaitableEvent from NULL handle";
+ // Tried to create WaitableEvent from NULL handle
+ CHECK(handle_.IsValid());
}
WaitableEvent::~WaitableEvent() = default;
@@ -136,8 +137,8 @@ size_t WaitableEvent::WaitMany(WaitableEvent** events, size_t count) {
base::debug::ScopedEventWaitActivity event_activity(events[0]);
HANDLE handles[MAXIMUM_WAIT_OBJECTS];
- CHECK_LE(count, static_cast<size_t>(MAXIMUM_WAIT_OBJECTS))
- << "Can only wait on " << MAXIMUM_WAIT_OBJECTS << " with WaitMany";
+ // Can only wait on |MAXIMUM_WAIT_OBJECTS| with WaitMany
+ CHECK_LE(count, static_cast<size_t>(MAXIMUM_WAIT_OBJECTS));
for (size_t i = 0; i < count; ++i)
handles[i] = events[i]->handle();

Powered by Google App Engine
This is Rietveld 408576698